Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ActiveFedora::Inheritance.base_class for deep File descendants #1211

Merged
merged 1 commit into from
Mar 7, 2017

Conversation

mbklein
Copy link
Member

@mbklein mbklein commented Mar 7, 2017

Fixes and adds tests for the following issue:

Given:

class A < ActiveFedora::File
end

class B < A
end

Expected:

> A.base_class
=> ActiveFedora::File
> B.base_class
=> ActiveFedora::File

Actual:

> A.base_class
=> ActiveFedora::File
> B.base_class
ActiveFedora::ActiveFedoraError: B doesn't belong in a hierarchy descending from ActiveFedora
from /Users/mbk836/Workspace/hydra/active_fedora/lib/active_fedora/inheritance.rb:18:in `base_class'

@jcoyne jcoyne merged commit 4ee1c0c into samvera:master Mar 7, 2017
@mbklein mbklein deleted the file-inheritance-fix branch March 7, 2017 18:06
@dazza-codes dazza-codes mentioned this pull request May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants