Fix 1219 #1230
Merged
Fix 1219 #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified in real app that with typo fixed this does work to avoid need for double index run on an empty solr repo to get proper permissions. Hooray.
* Old way wasn't discarding root url, but an arbitrary prioritized (permissions) url * Root url does need to be discarded, because it has no ID, and ActiveFedora::Base.find raises on the nil id it has. * this seems to be the most straightforward way to do it.
for this legacy method, to allow a one-line bugfix samvera#1222
- restores complexity check on ActiveFedora::Indexing.reindex_everything
jeremyf
approved these changes
Apr 6, 2017
|
Subsumes #1222 |
|
@barmintor can you rebase this when you get a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring root uri exclusion to conform to codestyle