Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release 12.1.0 #1365

Merged
merged 4 commits into from
Feb 28, 2019
Merged

Prepare release 12.1.0 #1365

merged 4 commits into from
Feb 28, 2019

Conversation

no-reply
Copy link
Contributor

@no-reply no-reply commented Sep 26, 2018 •
edited
Loading

@coveralls
Copy link

coveralls commented Sep 26, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 89.537% when pulling a51983a on release-2.1.0 into c4acd25 on master.

@no-reply
Copy link
Contributor Author

I'm very skeptical that coveraged decreased on this change. Thoughts?

cjcolvar
cjcolvar approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I don't see how the lines considered uncovered by coveralls could have been caused by this change.

@no-reply no-reply merged commit 4ef8660 into master Feb 28, 2019
@jcoyne jcoyne deleted the release-2.1.0 branch February 28, 2019 21:17
@jcoyne jcoyne restored the release-2.1.0 branch February 28, 2019 21:17
@jeremyf jeremyf deleted the release-2.1.0 branch January 23, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@no-reply @coveralls @cjcolvar