Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the version of rails that is used #1377

Merged
merged 3 commits into from
Feb 28, 2019
Merged

Pin the version of rails that is used #1377

merged 3 commits into from
Feb 28, 2019

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jan 24, 2019

rather than the version of activemodel.

This prevents the tests from installing rails 0.9.5, and not finding the generator code we depend on.

@jcoyne jcoyne changed the title Pin the version of rails that is used, rather than the version of act… Pin the version of rails that is used Jan 24, 2019
@jcoyne
Copy link
Member Author

jcoyne commented Jan 24, 2019

This fails due to:

Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    rails (= 4.2.10) was resolved to 4.2.10, which depends on
      bundler (>= 1.3.0, < 2.0)
  Current Bundler version:
    bundler (2.0.1)

@jcoyne
Copy link
Member Author

jcoyne commented Jan 24, 2019

I recommend that we drop Rails 4.2 from the test matrix.

@coveralls
Copy link

coveralls commented Jan 24, 2019

Coverage Status

Coverage increased (+0.05%) to 89.569% when pulling b8e22e5 on pin_rails into 4a6fd5f on master.

Gemfile Outdated
@@ -7,7 +7,7 @@ gemspec path: File.expand_path('..', __FILE__)
gem 'byebug' unless ENV['TRAVIS']
gem 'pry-byebug' unless ENV['CI']

gem 'activemodel', ENV['RAILS_VERSION'] if ENV['RAILS_VERSION']
gem 'rails', ENV['RAILS_VERSION'] if ENV['RAILS_VERSION']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ActiveFedora should not depend on all of Rails. We have a number of applications that are just ETL with ActiveFedora.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was your change. I think you had done that in the Gemfile here just for testing purposes since a really old version of rails was getting pulled in. I'll try rolling it back and see if it works with the pinning of bundler.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! That worked!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, sorry. Thanks for fixing it.

@jcoyne
Copy link
Member Author

jcoyne commented Feb 28, 2019

This looks great. Can someone do a "squash merge"?

Copy link
Contributor

@no-reply no-reply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@no-reply no-reply merged commit 2340951 into master Feb 28, 2019
@no-reply no-reply deleted the pin_rails branch February 28, 2019 19:28
@jrochkind
Copy link
Contributor

y'all know the actual code you merged, according to the github diff, seems to have nothing to do with rails (contra PR title), but does deal with pinning bundler versions?

@no-reply
Copy link
Contributor

@jrochkind I think that was discussed above, here: #1377 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants