Rails 6 #1403
Merged
Rails 6 #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 10, 2019 12:39
Rails 5.1 support is ended. ActiveFedora 14 will drop support.
This method is removed in ActiveModel 6.0, and is private anyway. Avoid calling it for upgradability.
We used to manually set `ActiveModel::Dirty` internals to track "previous changes". In Rails 6, these internals are completely rewritten and much more efficient. We can rely on the provided implementation instead of rolling our own.
Rails 6 is here. 🎉
cjcolvar
approved these changes
Sep 12, 2019
|
yeah, i was assuming we'd release 14.0.0 immediately. |
|
new plan, it's made backwards compatible in #1407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Rails 6. Drop support for 5.1.