Ruby3 Support #1489
Merged
Ruby3 Support #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 11, 2023
Closed
jrgriffiniii
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Thank you very much for this incredible amount of labor @cjcolvar !!! It is very greatly appreciated!
|
I am very sorry for blocking this, please know that samvera-labs/ActiveTriples#8 has been opened and is ready for review in support of this PR. |
Merged
dlpierce
reviewed
Jan 27, 2023
dlpierce
approved these changes
Jan 27, 2023
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ruby 3 by upgrading ldp and ActiveTriples as well switching to bixby in order to upgrade rubocop to a version with support for ruby 3. The upgrade to bixby required extensive styling fixes, but brings ActiveFedora in line with the rest of the core components.