Include ActiveModel::Dirty on Base, call field_will_change! on delegated methods, and track changes on save #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted methods, and track changes on save
|
👍 |
|
Looks good to me. 👍 |
jeremyf
added a commit
that referenced
this pull request
Aug 12, 2013
Include ActiveModel::Dirty on Base, call field_will_change! on delegated methods, and track changes on save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements ActiveModel::Dirty for ActiveFedora::Base objects. As discussed on the committer's call this might not be an ideal solution but might be best for now. Ideally, delegate would delegate all of the AM::Dirty calls to the appropriate datastream which would track the changes so obj.attribute_changed? and obj.datastream.attribute_changed? would both exist and report the same value. But given how OM works this might be hard to implement.