Added has_attributes to replace delegate_to #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to conflate attributes stored in the repository with delegating to methods. There are certain actions like change tracking or casting to a singular value (multiple: false) that we only want to do on persisted attributes. The previous implementation could break in certain cases when developers attempted to use ActiveSupport's delegate method.
jeremyf
added a commit
that referenced
this pull request
Oct 24, 2013
Added has_attributes to replace delegate_to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to conflate attributes stored in the repository with delegating
to methods. There are certain actions like change tracking or casting to
a singular value (multiple: false) that we only want to do on persisted
attributes. The previous implementation could break in certain cases when
developers attempted to use ActiveSupport's delegate method.