Allow chaining of #where with combination of string and hash arguments #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ombination of string and hash arguments to #where
|
This looks great 👍 |
mjgiarlo
added a commit
that referenced
this pull request
Mar 10, 2014
Allow chaining of #where with combination of string and hash arguments
| @@ -197,7 +197,7 @@ class Basic < ActiveFedora::Base | |||
| end | |||
| it "should allow conditions" do | |||
| mock_result = {'response'=>{'numFound'=>7}} | |||
| ActiveFedora::SolrService.should_receive(:query).with("#{@model_query} AND (foo:bar)", :rows=>0, :raw=>true).and_return(mock_result) | |||
| ActiveFedora::SolrService.should_receive(:query).with("#{@model_query} AND foo:bar", :rows=>0, :raw=>true).and_return(mock_result) | |||
There was a problem hiding this comment.
This test needs to be restored. The parentheses are needed for any where condition that has an OR including access control conditions. I'll update this PR once I've fixed this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted where_values to an array matching ActiveRecord and as mentioned here: samvera/hydra-head#152
This was also reported as a regression by terrellt.