Corrected method call to :loaded! in HasManyAssociation (fixes #383) #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +23,7 @@ def count_records | |||
| # If there's nothing in the database and @target has no new records | |||
| # we are certain the current target is an empty array. This is a | |||
| # documented side-effect of the method that may avoid an extra SELECT. | |||
| @target ||= [] and loaded if count == 0 | |||
| @target ||= [] and loaded! if count == 0 | |||
There was a problem hiding this comment.
Should and be && here? I'm not suggesting anything is broken, but using and near assignment operators can cause unexpected issues due to the difference in precedence between it and &&. (&& is higher precedence than ||= and and is lower than ||=.)
There was a problem hiding this comment.
I think it's okay. It was intended to be a copy of this:
https://github.com/rails/rails/blob/master/activerecord/lib/active_record/associations/has_many_association.rb#L69
jcoyne
added a commit
that referenced
this pull request
Apr 4, 2014
Corrected method call to :loaded! in HasManyAssociation (fixes #383)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test added to has_many_associations_spec.rb fails without the fix.
The changes to associations_spec.rb were incidental -- one to change an equality statement into an expectation.