Adding error for bad nested attribute arguments #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending a bad argument to Rdf::Resource#attributes= previously failed silently. This is a problem, since it makes modeling errors invisible to nested attributes setters, leading to missing data. Other Rails nested attributes seem to throw an ArgumentError. This PR mimics that behavior and message. Closes samvera#393.
jcoyne
added a commit
that referenced
this pull request
Apr 11, 2014
…nt-errors Adding error for bad nested attribute arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending a bad argument to Rdf::Resource#attributes= previously failed
silently. This is a problem, since it makes modeling errors invisible to
nested attributes setters, leading to missing data. Other Rails nested
attributes seem to throw an ArgumentError. This PR mimics that behavior
and message.
Closes #393.