Fixed bug in ActiveFedora::FinderMethods#load_from_fedora #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the test in this case is particularly unclear and highly dependent on the existing code structure. I'd like to see a test like: before { Foo.create('test:123') }
expect(ActiveFedora::Base.send(:load_from_fedora, "test:123", nil)).to be_kind_of Foo |
…casts when klass is ActiveFedora::Base and `cast' argument is nil, as intended. Fixes #431 since by default it calls load_from_fedora(pid, nil) on each hit.
| it "should cast when klass == ActiveFedora::Base and cast argument is nil" do | ||
| expect(relation.send(:load_from_fedora, "test:123", nil)).to be_a SpecModel::Basic | ||
| end | ||
| end |
There was a problem hiding this comment.
@jcoyne Is the above better?
|
👍 |
jcoyne
added a commit
that referenced
this pull request
Jun 19, 2014
Fixed bug in ActiveFedora::FinderMethods#load_from_fedora
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that it casts when klass is ActiveFedora::Base and `cast' argument is nil, as intended.
Fixes #431 since by default it calls load_from_fedora(pid, nil) on each hit.