Extracting object from .load_instance_from_solr #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracting .load_instance_from_solr to object Extracting #active_fedora_class for SolrInstance Tidying up SolrInstanceLoader#object Adding spec for missing pid SolrInstanceLoader Adding rudimentary doc SolrInstanceLoader Extracting SolrInstanceLoader to separate class
jcoyne
added a commit
that referenced
this pull request
Mar 26, 2013
…ding Extracting object from .load_instance_from_solr
| @@ -7,6 +7,7 @@ gemspec | |||
| group :development, :test do | |||
| gem 'simplecov', :platforms => [:mri_19]#, :mri_20] | |||
| gem 'simplecov-rcov', :platforms => [:mri_19]#, :mri_20] | |||
| gem 'debugger', :platforms => [:mri_19, :mri_20] | |||
There was a problem hiding this comment.
In the future, don't commit debugger to git. It's not necessary that everyone have this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting .load_instance_from_solr to object
Extracting #active_fedora_class for SolrInstance
Tidying up SolrInstanceLoader#object
Adding spec for missing pid SolrInstanceLoader
Adding rudimentary doc SolrInstanceLoader
Extracting SolrInstanceLoader to separate class