Adds fix for content-lenght value missing for files uploaded via ActionD... #622
Conversation
hectorcorrea
force-pushed
the
file_upload_fix
branch
from
0f479d6
to
7c47e59
Compare
| def initialize | ||
| @content = StringIO.new("hello world") | ||
| end | ||
| def bytesize |
There was a problem hiding this comment.
Please add some whitespace between the methods.
| @@ -254,6 +254,9 @@ def save(*) | |||
| payload = behaves_like_io?(content) ? content.read : content | |||
| headers = { 'Content-Type' => mime_type } | |||
| headers['Content-Disposition'] = "attachment; filename=\"#{@original_name}\"" if @original_name | |||
| # Setting the content-lenght is required until we figure out why Faraday | |||
| # is not doing this automatically for files uploaded via ActionDispatch. | |||
| headers['Content-Length'] = payload.size.to_s if payload.is_a?(ActionDispatch::Http::UploadedFile) | |||
There was a problem hiding this comment.
@jcoyne Although I like the payload.is_a? approach better than using payload.class.name == "ActionDispatch::Http::UploadedFile" that problem with payload.is_a? is that it will force a dependency between ActiveFedora and ActionDispatch::Http::UploadedFile and the code won't run unless the class ActionDispatch::Http::UploadedFile is defined.
I am thinking of reverting back to class.name == "ActionDispatch::Http::UploadedFile". Thoughts?
There was a problem hiding this comment.
@jcoyne I could also do defined?(ActionDispatch::Http::UploadedFile) and payload.is_a?(ActionDispatch::Http::UploadedFile)
That seems like a good compromise.
hectorcorrea
force-pushed
the
file_upload_fix
branch
from
7c47e59
to
30275f9
Compare
| @@ -292,6 +295,10 @@ def stream(range = nil, &block) | |||
|
|
|||
| private | |||
|
|
|||
| def is_actiondispatch_uploadedfile?(payload) | |||
There was a problem hiding this comment.
How about something shorter like def uploaded_file?(payload) or is that misleading?
There was a problem hiding this comment.
@mjgiarlo I like the shorter name better too. I can go either way.
…onDispatch:Http::UploadedFile
hectorcorrea
force-pushed
the
file_upload_fix
branch
from
30275f9
to
979b068
Compare
Adds fix for content-lenght value missing for files uploaded via ActionD...
...ispatch:Http::UploadedFile