Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return array of version uris #628

Merged
merged 1 commit into from
Dec 3, 2014
Merged

Return array of version uris #628

merged 1 commit into from
Dec 3, 2014

Conversation

awead
Copy link
Contributor

@awead awead commented Dec 3, 2014

Fixes #625 and #627. Returns array of uris for every version. This also addresses issues with fixity checking in Sufia where you can now check the fixity of a specific version:

object.versions.each do |uri|
  ActiveFedora::FixityService.new(uri).check
end

@awead
Copy link
Contributor Author

awead commented Dec 3, 2014

Don't merge this yet. I need to add a test case for fixity checking of each version.

end

def version label
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about version_uri because we are returning the URI, not the version metadata or content.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ed4547f on versions into 06d405b on fedora-4.

Added tests to support fixity checking of versioned resources.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 39e55de on versions into 06d405b on fedora-4.

@awead
Copy link
Contributor Author

awead commented Dec 3, 2014

@jcoyne Travis is passing now and I've updated this PR per your comments.

jcoyne added a commit that referenced this pull request Dec 3, 2014
@jcoyne jcoyne merged commit 3e343fa into fedora-4 Dec 3, 2014
@jcoyne jcoyne deleted the versions branch December 3, 2014 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants