Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github issue 48 tests and YARD #629

Merged
merged 2 commits into from
Dec 4, 2014
Merged

github issue 48 tests and YARD #629

merged 2 commits into from
Dec 4, 2014

Conversation

barmintor
Copy link
Member

#48

@barmintor barmintor mentioned this pull request Dec 3, 2014
Closed
mjgiarlo
mjgiarlo reviewed Dec 4, 2014
View reviewed changes
spec/integration/datastreams_spec.rb
end

describe "#create_datastream" do
before :each do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop the explicit :each here.

@mjgiarlo
Copy link
Member

mjgiarlo commented Dec 4, 2014

Thanks for the changes, @barmintor. ⌚ on Travis.

@mjgiarlo
Copy link
Member

mjgiarlo commented Dec 4, 2014

Looks 🆗 to me. Would you mind squashing your commits?

@barmintor
Copy link
Member Author

[7:22pm] barmintor: hmm. hey mjgiarlo: since those changes ought to be made in the rest of the spec, too I’m inclined to make it a sep commit. Thoughts?
[7:24pm] mjgiarlo: barmintor: meh
[7:24pm] mjgiarlo: barmintor: translation: either works for me.
[7:25pm] mjgiarlo: barmintor: making just those changes is fine by me. breaking into two commits so you can extend these changes to more of the code is fine by me.

@barmintor
github issue 48 tests and YARD
89809b4 
update datastreams_spec syntax
@barmintor
Copy link
Member Author

Squashed.

jcoyne added a commit that referenced this pull request Dec 4, 2014
@jcoyne
Merge pull request #629 from projecthydra/issue_48
d06db81 
github issue 48 tests and YARD
@jcoyne jcoyne merged commit d06db81 into 8.0-stable Dec 4, 2014
@jcoyne jcoyne deleted the issue_48 branch December 4, 2014 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barmintor @mjgiarlo @jcoyne