Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reindex_everything should ignore non-RDF sources #663

Merged
merged 1 commit into from
Jan 5, 2015

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jan 2, 2015

Because they don't have parsable graphs.

Because they don't have parsable graphs.
@jcoyne
Copy link
Member Author

jcoyne commented Jan 2, 2015

@mjgiarlo this should solve the problem you have with https://gist.github.com/mjgiarlo/a15bc935ba26ab6723f2

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9604df1 on reindex_avoids_non_rdf_sources into * on master*.

@mjgiarlo
Copy link
Member

mjgiarlo commented Jan 3, 2015

👍

@mjgiarlo
Copy link
Member

mjgiarlo commented Jan 3, 2015

Comments from others?

@acoburn
Copy link

acoburn commented Jan 3, 2015

Is it possible that you would have metadata attached to the non-RDF (binary) node? For instance, technical metadata or other preservation-related data specific to the binary (as opposed to the parent object). I at least, was planning to put certain types of technical metadata on the {binary path}/fcr:metadata endpoint. On the other hand, I probably won't be using solrizer for indexing, so don't consider this a particularly strong concern.

@jcoyne
Copy link
Member Author

jcoyne commented Jan 3, 2015

@acoburn In that case the non-RDF's parent is responsible for doing the indexing of its children. Regardless of that fact, this PR does not affect the current behavior in any way aside from preventing the stack trace that @mjgiarlo encountered.

@acoburn
Copy link

acoburn commented Jan 3, 2015

@jcoyne thanks for the explanation!

mjgiarlo added a commit that referenced this pull request Jan 5, 2015
reindex_everything should ignore non-RDF sources
@mjgiarlo mjgiarlo merged commit 63e9aed into master Jan 5, 2015
@mjgiarlo mjgiarlo deleted the reindex_avoids_non_rdf_sources branch January 5, 2015 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants