Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary HEAD request on file retrieval. Fixes #493 #711

Merged
merged 1 commit into from
Feb 11, 2015

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Feb 8, 2015

If a NonRDFSource has a parent which is an RDFSource (AF::Base) and the
parent indicates that it contains the file (ldp:contains) then there is
no need to send a HEAD request to see if the file exists.

If a NonRDFSource has a parent which is an RDFSource (AF::Base) and the
parent indicates that it contains the file (ldp:contains) then there is
no need to send a HEAD request to see if the file exists.
@mjgiarlo
Copy link
Member

mjgiarlo commented Feb 8, 2015

Major fails there.

@mjgiarlo
Copy link
Member

mjgiarlo commented Feb 8, 2015

Looks like it's related to a missing dependency on 'zip' from jettywrapper. @barmintor ⁉️ ⁉️ ⁉️

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 92.76% when pulling 92e106f on optimize_file_retrieval into d14c553 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 92.76% when pulling 92e106f on optimize_file_retrieval into d14c553 on master.

carolyncole added a commit that referenced this pull request Feb 11, 2015
Avoid unnecessary HEAD request on file retrieval. Fixes #493
@carolyncole carolyncole merged commit 51edc96 into master Feb 11, 2015
@jcoyne jcoyne deleted the optimize_file_retrieval branch March 13, 2015 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants