-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a mechanism to set rdf_label on the ActiveTriple resource #747
Conversation
👍 |
@jcoyne Could you just extend https://github.com/ActiveTriples/ActiveTriples/blob/master/lib/active_triples/configurable.rb and then populate the resource with that? Although we may need to add something to AT to keep track of what configuration options were set. |
@terrellt I don't think that's possible, because this is on the AF::Base, not on a Resource. I'd be happy if you proved me wrong though. |
1 similar comment
@jcoyne Using the AT API would look like this: rdf_label...terrellt:rdf_label Ideally https://github.com/projecthydra/active_fedora/pull/747/files#diff-4827a9cc4420720ae18bf842f60f18f5R94 could be replaced by a method in AT. The only concern I would have is method name collision. |
@terrellt nice idea, but it's not backwards compatible with 9.0.4 |
private | ||
# @return a Hash of options suitable for passing to ActiveTriples::Base.configure | ||
def active_triple_options | ||
{}.tap do |h| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this getting tap
ped for hash generation? Its a bit confusing.
Why not { type: type, rdf_label: rdf_label }
?
1 similar comment
👍 though waiting on @terrellt for either a response or to push the Merge button |
Add a mechanism to set rdf_label on the ActiveTriple resource
No description provided.