Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mechanism to set rdf_label on the ActiveTriple resource #747

Merged
merged 1 commit into from
Apr 6, 2015

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Apr 2, 2015

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.94% when pulling 3b82b39 on rdf_label into ee566ed on master.

@mjgiarlo
Copy link
Member

mjgiarlo commented Apr 2, 2015

👍

@tpendragon
Copy link
Contributor

@jcoyne Could you just extend https://github.com/ActiveTriples/ActiveTriples/blob/master/lib/active_triples/configurable.rb and then populate the resource with that? Although we may need to add something to AT to keep track of what configuration options were set.

@jcoyne
Copy link
Member Author

jcoyne commented Apr 2, 2015

@terrellt I don't think that's possible, because this is on the AF::Base, not on a Resource. I'd be happy if you proved me wrong though.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 92.96% when pulling 9e2f1c3 on rdf_label into ee566ed on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 92.96% when pulling 9e2f1c3 on rdf_label into ee566ed on master.

@tpendragon
Copy link
Contributor

@jcoyne Using the AT API would look like this: rdf_label...terrellt:rdf_label

Ideally https://github.com/projecthydra/active_fedora/pull/747/files#diff-4827a9cc4420720ae18bf842f60f18f5R94 could be replaced by a method in AT.

The only concern I would have is method name collision.

@jcoyne
Copy link
Member Author

jcoyne commented Apr 2, 2015

@terrellt nice idea, but it's not backwards compatible with 9.0.4

private
# @return a Hash of options suitable for passing to ActiveTriples::Base.configure
def active_triple_options
{}.tap do |h|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this getting tapped for hash generation? Its a bit confusing.

Why not { type: type, rdf_label: rdf_label }?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 93.05% when pulling 6d9004e on rdf_label into a95a398 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 93.05% when pulling 6d9004e on rdf_label into a95a398 on master.

@jeremyf
Copy link
Contributor

jeremyf commented Apr 6, 2015

👍 though waiting on @terrellt for either a response or to push the Merge button

tpendragon pushed a commit that referenced this pull request Apr 6, 2015
Add a mechanism to set rdf_label on the ActiveTriple resource
@tpendragon tpendragon merged commit 14566e3 into master Apr 6, 2015
@tpendragon tpendragon deleted the rdf_label branch April 6, 2015 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants