Sort versions as dates not as strings #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
👍 |
|
Looks good to me. |
| end | ||
| versions.sort_by { |version| DateTime.parse(version.created) } |
There was a problem hiding this comment.
What happens here is one version.created cannot be parsed as a valid date?
There was a problem hiding this comment.
It seems reasonable to raise an exception if Fedora is giving us a non-date here.
mjgiarlo
force-pushed
the
sort_versions_as_dates
branch
from
1bce0cc
to
931c24a
Compare
|
👍 Waiting on Travis.... |
jcoyne
added a commit
that referenced
this pull request
Apr 3, 2015
Sort versions as dates not as strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.