Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type validator objects to associations. #867

Merged
merged 1 commit into from
Jul 27, 2015

Conversation

tpendragon
Copy link
Contributor

This allows for a good interaction point for adding additional type validations
to associations.

@mjgiarlo
Copy link
Member

@terrellt One failing spec:

  1) ActiveFedora::Associations::Builder::HasAndBelongsToMany valid_options should eq [:class_name, :predicate, :before_add, :after_add, :before_remove, :after_remove, :inverse_of, :solr_page_size, :autosave]
     Failure/Error: it { should eq [:class_name, :predicate, :before_add, :after_add, :before_remove,

       expected: [:class_name, :predicate, :before_add, :after_add, :before_remove, :after_remove, :inverse_of, :solr_page_size, :autosave]
            got: [:class_name, :predicate, :type_validator, :before_add, :after_add, :before_remove, :after_remove, :inverse_of, :solr_page_size, :autosave]

       (compared using ==)

       Diff:
       @@ -1,5 +1,6 @@
        [:class_name,
         :predicate,
       + :type_validator,
         :before_add,
         :after_add,
         :before_remove,

This allows for a good interaction point for adding additional type validations
to associations.
@tpendragon
Copy link
Contributor Author

@mjgiarlo Fixed.

@mjgiarlo
Copy link
Member

👍

mjgiarlo added a commit that referenced this pull request Jul 27, 2015
Add type validator objects to associations.
@mjgiarlo mjgiarlo merged commit 5466c65 into samvera:master Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants