Allow for sub RDF Sources via contains #901
Conversation
|
A side-note - this may get us close to a fix for #858 |
|
|
||
| module ActiveFedora | ||
| class AssociationHash | ||
| extend Forwardable |
There was a problem hiding this comment.
Why does this extend Forwardable?
There was a problem hiding this comment.
No idea. As far as I can tell it doesn't use it - was brought over from FilesHash. I could remove it, but I'm not sure what the project's policy on refactors + feature requests in one PR is.
There was a problem hiding this comment.
Unless @jcoyne voices an objection, I'd say dump it. It's a new file, so meh.
|
Do we really want to make a clear distinction between attached files and child_resources? I'd prefer we handle them in the same way if possible. |
|
@jcoyne Can you take another look? Did some work to combine handling files and nested rdf sources. |
tpendragon
force-pushed
the
sub_resources
branch
from
03bfcb8
to
d4a55c7
Compare
|
Rebased/Squashed |
| @@ -20,7 +20,7 @@ def each | |||
| private | |||
|
|
|||
| def convert(id) | |||
| if id.start_with?("http") | |||
There was a problem hiding this comment.
Please add YARD documentation on the parameter please
There was a problem hiding this comment.
For the private method?
tpendragon
force-pushed
the
sub_resources
branch
2 times, most recently
from
9524539
to
cfa0f65
Compare
tpendragon
force-pushed
the
sub_resources
branch
from
cfa0f65
to
02eecf7
Compare
Allow for sub RDF Sources via contains
I'll squash this when it's okay - for now it shows a refactor route.