Support both Fedora and Premis predicates, supports Fedora 4.4 #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it worth modifying FixityService to support checks made to all versions of Fedora 4? This would mean querying for three difference predicates:
|
|
I think we should probably attempt to support at least 4.4.0 and 4.3.0, so we should probably query for both URIs. I think there are only 2 though. Aren't the first two bullet points the same predicate? It's just that it's no longer in the most recent version of rdf-vocab, which is why we moved it to a hard coded uri. |
|
@jcoyne yeah, that looks right. I'll update the PR. |
awead
force-pushed
the
fedora4.4-upgrade
branch
from
303ef9f
to
1f320f1
Compare
awead
changed the title
|
@jcoyne I tested it locally under Fedora 4.3 and 4.4, and all is well. Travis should be testing it using 4.4, now that hydra-jetty is updated. |
jcoyne
added a commit
that referenced
this pull request
Oct 16, 2015
Support both Fedora and Premis predicates, supports Fedora 4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixity predicates have changed. We'll need to release a new version of AF once this is merged, but it requires an update to hydra-jetty.