query for nil creates correct query #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
fix_query_nil
branch
4 times, most recently
from
fb3ba7e
to
8875e7c
Compare
Previously querying for a field to be nil (e.g. library_id: nil) would just ignore that restriction and return all records. Now it actually queryies for records that don't have library_id set (e.g. -library_id:[* TO *]) Fixes #910
mjgiarlo
added a commit
that referenced
this pull request
Oct 16, 2015
query for nil creates correct query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously querying for a field to be nil (e.g. library_id: nil) would
just ignore that restriction and return all records. Now it actually
queryies for records that don't have library_id set (e.g.
-library_id:[* TO *]) Fixes #910