Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove parents column serialization in the importer run #443

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

alishaevn
Copy link
Contributor

@alishaevn alishaevn commented Mar 17, 2022

related: #439

summary

I dropped, created, migrated and seeded the db on louisville. afterwards, it updated the schema. after this change, I was unable to even access the importer dashboard page because of the error below.

on the related pr above, we removed the default value of the parents array, which is what I believe makes the serialization no longer necessary.

expected behavior

  • an import can be successfully run after updating bulkrax in a client app to the 9a12f142 commit on main

demo

before after
Screen Shot 2022-03-17 at 2 44 19 PM image

@alishaevn alishaevn merged commit 8e93a18 into main Mar 17, 2022
@alishaevn alishaevn deleted the remove-parents-serialization branch August 5, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants