undefined-method-length-for-nil-class #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ield_mapping_hash_for
alishaevn
commented
Jul 18, 2022
| instance_variable_set( | ||
| "@#{key}_hash", | ||
| mapping&.with_indifferent_access&.select { |_, h| h.key?(key) } |
There was a problem hiding this comment.
because Bulkrax::Exporter.find(2).field_mapping was returning nil, line 81 returned nil. this resulted in an error on line 83 because instance_variable_get("@#{key}_hash") evaluated to nil and nil.length throws an error.
alishaevn
commented
Jul 18, 2022
alishaevn
commented
Jul 18, 2022
| @@ -75,7 +75,7 @@ def related_children_parsed_mapping | |||
| def get_field_mapping_hash_for(key) | |||
| return instance_variable_get("@#{key}_hash") if instance_variable_get("@#{key}_hash").present? | |||
|
|
|||
| mapping = importerexporter.field_mapping == [{}] ? {} : importerexporter.field_mapping | |||
| mapping = importerexporter.field_mapping.is_a?(Hash) ? importerexporter.field_mapping : {} | |||
There was a problem hiding this comment.
either return the valid field mapping, or {} in all cases.
alishaevn
requested review from
sephirothkod,
ShanaLMoore,
bkiahstroud and
kirkkwang
sephirothkod
approved these changes
Jul 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
ran into this issue while running this rake task on pals for all exporters that were exporting from a collection after updating to
v4.1.0sentry error: https://sentry.notch8.com/sentry/pals/issues/142067/
expected behavior
importerexporter.field_mappingisnilin the "get_field_mapping_hash_for" methoddemo