ignore-misidentified-collection-entries #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alishaevn
commented
Jul 19, 2022
| @@ -324,7 +324,7 @@ def retrieve_cloud_files(files) | |||
| def write_files | |||
| require 'open-uri' | |||
| folder_count = 0 | |||
| sorted_entries = sort_entries(importerexporter.entries) | |||
| sorted_entries = sort_entries(importerexporter.entries.uniq(&:identifier)) | |||
There was a problem hiding this comment.
before #597, child collections were exported as a CsvEntry class instead of CsvCollectionEntry. this means that when that importer/exporter is run again, the old entry still exists, but a new one is created as well. we want to get the newest one.
irb(main):148:0> current_record_ids.count
=> 13
irb(main):149:0> Bulkrax::Exporter.find(59).entries.count
=> 14
Bulkrax::Exporter.find(59).entries.uniq(&:identifier).count
=> 13
alishaevn
changed the title
sephirothkod
approved these changes
Jul 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
ran into this issue while running this rake task on pals for all exporters that were exporting from a collection after updating to
v4.1.0sentry error: https://sentry.notch8.com/sentry/pals/issues/142068/
demo
before #597, child collections were exported as a CsvEntry class instead of CsvCollectionEntry. this means that when that importer/exporter is run again, the old entry still exists, but a new one is created as well. the newer entry is at index 0, so calling
uniqon the identifier value (as seen below), returns index 0.expected behavior