🎁 Add title attribute #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will add title attribute to sidebar links for hover information display.
kirkkwang
force-pushed
the
add-title-attribute
branch
from
2ff4695
to
0c0377b
Compare
jeremyf
approved these changes
Jul 20, 2023
kirkkwang
added a commit
to scientist-softserv/utk-hyku
that referenced
this pull request
Jul 20, 2023
This commit will add title attribute to sidebar links for hover information display. Some translations were missing in the yml so I added those as well but only for English. At some point we might want to add support for other languages. Bulkrax and AllinsonFlex had some of the partials in the sidebar so those were also modified and the revisions for those gems were updated. Ref: - samvera-labs/allinson_flex#120 - samvera/bulkrax#838 - #41
kirkkwang
added a commit
to scientist-softserv/utk-hyku
that referenced
this pull request
Jul 20, 2023
This commit will update the revisions of `Bulkrax` and `AllinsonFlex` to the latest versions to bring in the views changes for the admin dashboard sidebar. Also, this commit moves the js require for Bulkrax up above the dataTables require to fix the issue with the admin jquery throwing errors. This was likely due to a recent change to make Bulkrax work better with Hydra. Ref: - samvera/bulkrax#836 - samvera-labs/allinson_flex#120 - samvera/bulkrax#838
kirkkwang
added a commit
to scientist-softserv/utk-hyku
that referenced
this pull request
Jul 21, 2023
This commit will update the revisions of `Bulkrax` and `AllinsonFlex` to the latest versions to bring in the views changes for the admin dashboard sidebar. Also, this commit moves the js require for Bulkrax up above the jQuery requires to fix the issue with the admin jQuery throwing errors. This was likely due to a recent change to make Bulkrax work better with Hydra. Ref: - samvera/bulkrax#836 - samvera-labs/allinson_flex#120 - samvera/bulkrax#838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will add the
titleattribute to the list tags so when users hover over the links they will see the name of the link on the dashboard.