5.4.0-bug-fixes #865
5.4.0-bug-fixes #865
Conversation
there was an extra "x" in the app/views/bulkrax/importers/_oai_fields.html.erb file. it threw a syntax error when trying to create a new importer.
| # ref: https://github.com/samvera-labs/bulkrax/issues/866 | ||
| # ref:https://github.com/samvera-labs/bulkrax/issues/867 | ||
| # work_index = ::ActiveFedora.index_field_mapper.solr_name(work_identifier, :facetable) | ||
| work_index = work_identifier | ||
| query = { work_index => |
There was a problem hiding this comment.
I don’t see why this would work Alisha. The solr search needs the _ssim version not just field name but field name plus solr extension
There was a problem hiding this comment.
in solr the version is actually source_tesim, not source_ssim. however, the call to AF gives us source_sim, which is still wrong.
screenshots
There was a problem hiding this comment.
Which project is this? I'm afraid that what's likely in play is that the field name may need to be configured. And this fix will break other implementations.
There was a problem hiding this comment.
@jeremyf She noticed this in prep for her workshop so this was basically tested against hyku proper. (but technically the samvera training repo)
There was a problem hiding this comment.
yes, I'm working against https://github.com/scientist-softserv/softserv-training-workshops-2023. I'm fine if this needs to change in the future as I'm locking my exercise to v5.4.1.
I tried looking into the AF method a little, but I was already tryna just get the stuff to work.
I also noticed several things have changed that don't appear to have been updated in the wiki.
There was a problem hiding this comment.
I've assigned both of the referenced issues above to @orangewolf per his request.
* main: (24 commits) Retry and delete take 2 (#894) 🎁 Add `Bulkrax.persistence_adapter` (#895) 💸 Mint v6.0.1 (#892) 🐛 Fix #work_identifier_search_field logic (#891) 💸 Bump to v6.0.0 (#889) make search string used to look up objects configurable (#884) 💸 v5.5.0 (#888) unpin dry-monads. its not a dependency of bulkrax (#885) fix syntax error in ERB (#883) add support for Rails 6, Hyrax 4, and Blacklight 7 (#782) Reduce SQL calls when incrementing/decrementing run counters (#881) Update readme to remove references to samvera-labs (#880) add Compatibility section to readme (#879) 🐛 Fix tabs for Hydra application (#875) Nav-tabs event scoping (#874) 📚 Update docs in preparation for best practices seminar (#873) use the `GlobalID` library tooling to determine global id (#869) Avoid NoMethodError in Bulkrax::Importers::Controller#create. (#870) preparing to deploy v5.4.1 (#868) 5.4.0-bug-fixes (#865) ...
story
030103d
restore the ability to load the "/importers" page.
there was an extra "x" in the app/views/bulkrax/importers/_oai_fields.html.erb file. it threw a syntax error when trying to create a new importer.
error
99e6716
restore our ability to properly look up works by their work_identifier
ObjectFactory#search_by_identifierbug #866::ActiveFedora.index_field_mapper.solr_namesearch #867error