Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Migrate persistence layer methods to object factory #911

Merged
merged 6 commits into from
Feb 7, 2024
Merged

♻️ Migrate persistence layer methods to object factory #911

merged 6 commits into from
Feb 7, 2024

Commits on Feb 7, 2024

  1. ♻️ Migrate persistence layer methods to object factory 

    In review of the code and in brief discussion with @orangewolf, the
methods of the persistence layer could be added to the object factory.

We already were configuring the corresponding object factory for each
implementation of Bulkrax; so leveraging that configuration made
tremendous sense.

The methods on the persistence layer remain helpful (perhaps necessary)
for documented reasons in the `Bulkrax::ObjectFactoryInterface` module.

See:

- #895 and its discussion
    @jeremyf
    jeremyf committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    a04640b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into migrate-persistence-layer-to-object-factory 

    * main:
  importer failure helpers (#859)
    @jeremyf
    jeremyf committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    0dc3729 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into migrate-persistence-layer-to-object-factory 

    * main:
  ⚙️ Adding dry-monads as development dependency
    @jeremyf
    jeremyf committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    518fa42 View commit details
    Browse the repository at this point in the history

  4. 🎁 Add Valkyrie object factory interface methods

    @jeremyf
    jeremyf committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    cba1303 View commit details
    Browse the repository at this point in the history

  5. 🧹 Favor interface based exception 

    Given that we are not directly exposing ActiveFedora nor Hyrax nor
Valkyrie objects, we want to translate/transform exceptions into a
common exception based on an interface.

That way downstream implementers can catch the Bulkrax specific error
and not need to do things such as `if
defined?(ActiveFedora::RecordInvalid) rescue
ActiveFedora::RecordInvalid`

It's just funny looking.
    @jeremyf
    jeremyf committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    986faf3 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'hyrax-4-valkyrie-support' into migrate-persistence-laye… 

    …r-to-object-factory

* hyrax-4-valkyrie-support:
    @jeremyf
    jeremyf committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    7d3fc3f View commit details
    Browse the repository at this point in the history