fix a memory leak when copying large files by using the hyrax uploader #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r instead of a custom one
ShanaLMoore
reviewed
Jun 12, 2024
| @@ -243,18 +243,14 @@ def update_file_set(attrs) | |||
| def handle_remote_file(remote_file:, actor:, update: false) | |||
There was a problem hiding this comment.
with these changes, update is an unused parameter. Do we still need it in the signature/calls?
There was a problem hiding this comment.
yes, probably. I walked the code path and I think calling create_content all the time instead of sometimes calling update_content is the right call. You are attaching an unknowable file (remote source could change it) if you are downloading it from a url, so it makes sense to me that it has to be treated as new. I only have a confidence level of 72.5% on this though
ShanaLMoore
reviewed
Jun 12, 2024
bkiahstroud
reviewed
Jun 12, 2024
Co-authored-by: Shana Moore <shana.lavina.moore@gmail.com>
bkiahstroud
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of a custom one