Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i91 - saving nil object caused errors #962

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Jun 18, 2024

object equals nil here. but @object returned what we were looking for. Update code so that we save @object instead of saving nil, which rightfully raised errors.

Related issue:

Tested from Hyku to verify this works:

image

split-embargo-hyku.zip

object equals nil here. but @object returned what we were looking for. Update code so that we save @object instead of saving nil, which rightfully raised errors.

Related issue:
- scientist-softserv/palni_palci_knapsack#91
@ShanaLMoore ShanaLMoore added the patch-ver for release notes label Jun 18, 2024
@ShanaLMoore ShanaLMoore marked this pull request as ready for review June 19, 2024 15:37
@ShanaLMoore ShanaLMoore merged commit 078fa6e into main Jun 19, 2024
6 of 7 checks passed
@ShanaLMoore ShanaLMoore deleted the i91-bulkrax-import-bug branch June 19, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants