🐛 Refactor: Fix file path access to prevent error #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Centralized the import_file_path logic into a separate method - Resolved TypeError caused by nil values when checking file existence - Improved code readability and maintainability
1 task
kirkkwang
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When testing the OAI importer on Adventist valkyrie, we received the following error. The error was caused because oai imports from a feed, so no original file exists. When checking, instead of returning false it returned nil, and thus caused a TypeError.
related:
Screenshots / Video
BEFORE
AFTER
Expected Behavior
The site will not break when an original file doesn't exist.
Notes
🐛 Refactor: Fix file path access to prevent error
970ad45