Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bulkrax: OAI Imports Fail #723

Closed
1 task
ShanaLMoore opened this issue Aug 2, 2024 · 3 comments
Closed
1 task

🐛 Bulkrax: OAI Imports Fail #723

ShanaLMoore opened this issue Aug 2, 2024 · 3 comments
Assignees
@ShanaLMoore
Labels
bug something isn't working Bulkrax Valkyrie

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Aug 2, 2024 •
edited
Loading

Summary

I attempted to import the following:

Image

I can see that the import failed:

Image

However, when I click on the importer I get this error:
Update: (resolved by this PR)

Image

The actual error:

Image

Image

Acceptance Criteria

  • A user should be able to import from an OAI feed

Testing Instructions

Recreate the attempted importer (see screenshot in the summary section). set the limit to 10.
The importer should complete without errors.

Notes

The oai importer appears to be broken on staging too, pre valkyrie
@ShanaLMoore ShanaLMoore added bug something isn't working Bulkrax Valkyrie labels Aug 2, 2024
@ShanaLMoore ShanaLMoore self-assigned this Aug 2, 2024
@ShanaLMoore ShanaLMoore mentioned this issue Aug 2, 2024
Merged
@ShanaLMoore ShanaLMoore removed their assignment Aug 2, 2024
@ShanaLMoore ShanaLMoore mentioned this issue Aug 5, 2024
Closed
@ShanaLMoore
Copy link
Contributor Author

Because Rob already has oai jobs enqueue, the concern to create a new importer can be addressed later so I'll remove high priority from this ticket.

@ShanaLMoore ShanaLMoore self-assigned this Aug 6, 2024
@ShanaLMoore
Copy link
Contributor Author

from bulkrax branch handle-remote-files-for-valkyrie, the importer succeeds now. However the labels look wrong.

Image

Staging:

Image

Local:

Image

@ShanaLMoore ShanaLMoore mentioned this issue Aug 7, 2024
Merged
@jillpe jillpe closed this as completed Aug 8, 2024
@jillpe jillpe reopened this Aug 8, 2024
laritakr added a commit to samvera/bulkrax that referenced this issue Aug 13, 2024
@laritakr
Completes import with remote files
f023b2e 
- Provides a valkyrized way to import from a remote url.
- Supports additional file set arguments if present.
- Adds filename to Hyrax's UploadedFile table, to allow overriding of
carrierwave's default file name behavior.

refs
- scientist-softserv/adventist_knapsack#708
- scientist-softserv/adventist_knapsack#723
ShanaLMoore added a commit to samvera/bulkrax that referenced this issue Aug 14, 2024
@ShanaLMoore @laritakr
🧹 expands the ability to upload remote_files for valkyrie (#967)
176b11a 
* 🧹 expands the ability to upload remote_files for valkyrie resources

Previously this code strictly downloaded from s3 buckets. This was limiting, and expands the ability to import remote files without s3.

* Adds ability to set filename

* remove comment

* adds ability to import thumbnail_url

* Completes import with remote files

- Provides a valkyrized way to import from a remote url.
- Supports additional file set arguments if present.
- Adds filename to Hyrax's UploadedFile table, to allow overriding of
carrierwave's default file name behavior.

refs
- scientist-softserv/adventist_knapsack#708
- scientist-softserv/adventist_knapsack#723

* 💄 fix rubocop errors

* 🧹 fix for failing migration

error: NoMethodError: undefined method `column_exists' for #<AddFileNameToUploadedFiles:0x000055d8c48ea0b0 @name="AddFileNameToUploadedFiles", @Version=20240806161142, @connection=nil>

---------

Co-authored-by: LaRita Robinson <larita@scientist.com>
@ShanaLMoore ShanaLMoore mentioned this issue Aug 14, 2024
Merged
ShanaLMoore added a commit that referenced this issue Aug 14, 2024
@ShanaLMoore
Oai customizations (#735)
f3c3273 
# Story

Locally, point to bulkrax branch: handle-remote-files-for-valkyrie

Refs

- #708
- #723

# Expected Behavior Before Changes

# Expected Behavior After Changes

# Screenshots / Video

<details>
<summary></summary>

</details>

# Notes
@sjproctor
Copy link
Contributor

I think this worked for me.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShanaLMoore ShanaLMoore

Labels
bug something isn't working Bulkrax Valkyrie
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ShanaLMoore @sjproctor @jillpe