Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thumbnail_url override #708

Closed
1 of 2 tasks
Tracked by #688
ShanaLMoore opened this issue Jul 23, 2024 · 2 comments
Closed
1 of 2 tasks
Tracked by #688

thumbnail_url override #708

ShanaLMoore opened this issue Jul 23, 2024 · 2 comments
Assignees
@ShanaLMoore @laritakr
Labels
Bulkrax high priority Valkyrie

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jul 23, 2024 •
edited by laritakr
Loading

Summary

app/actors/hyrax/actors/create_with_remote_files_actor_decorator.rb needs to be valkyrized by turning it into a transaction.

History

This transaction will be needed to set the override_default_thumbnail property of FileSet. This property will need to get added to the file set metadata for the valkyrie resource. indexers will need to be updated as well.

related to:

ref:

image

ref:

Acceptance Criteria

  • Upon saving, Valkyrie resources still undergo the same process as Active Fedora records.

Screenshots or Video

Testing Instructions

  • Do an OAI importer or a CSV importer that includes thumbnail_url
  • The thumbnail url should be added to the work as a fileset
  • Edit the work that was created
  • The thumbnail should be set as the thumbnail of the work

Notes
@ShanaLMoore ShanaLMoore mentioned this issue Jul 23, 2024
Closed
11 tasks
@ShanaLMoore ShanaLMoore mentioned this issue Aug 5, 2024
Closed
5 tasks
@ShanaLMoore ShanaLMoore self-assigned this Aug 6, 2024
@ShanaLMoore ShanaLMoore mentioned this issue Aug 7, 2024
Merged
@ShanaLMoore ShanaLMoore changed the title Convert create_with_remote_files_actor_decorator.rb into a transaction thumbnail_url override Aug 8, 2024
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Aug 12, 2024 •
edited
Loading

2 tasks

  • get thumbnail url boolean into valkyrie
  • set listener to update thumbnail

laritakr added a commit to samvera/bulkrax that referenced this issue Aug 13, 2024
@laritakr
Completes import with remote files
f023b2e 
- Provides a valkyrized way to import from a remote url.
- Supports additional file set arguments if present.
- Adds filename to Hyrax's UploadedFile table, to allow overriding of
carrierwave's default file name behavior.

refs
- scientist-softserv/adventist_knapsack#708
- scientist-softserv/adventist_knapsack#723
@ShanaLMoore ShanaLMoore mentioned this issue Aug 13, 2024
Merged
ShanaLMoore added a commit to samvera/bulkrax that referenced this issue Aug 14, 2024
@ShanaLMoore @laritakr
🧹 expands the ability to upload remote_files for valkyrie (#967)
176b11a 
* 🧹 expands the ability to upload remote_files for valkyrie resources

Previously this code strictly downloaded from s3 buckets. This was limiting, and expands the ability to import remote files without s3.

* Adds ability to set filename

* remove comment

* adds ability to import thumbnail_url

* Completes import with remote files

- Provides a valkyrized way to import from a remote url.
- Supports additional file set arguments if present.
- Adds filename to Hyrax's UploadedFile table, to allow overriding of
carrierwave's default file name behavior.

refs
- scientist-softserv/adventist_knapsack#708
- scientist-softserv/adventist_knapsack#723

* 💄 fix rubocop errors

* 🧹 fix for failing migration

error: NoMethodError: undefined method `column_exists' for #<AddFileNameToUploadedFiles:0x000055d8c48ea0b0 @name="AddFileNameToUploadedFiles", @Version=20240806161142, @connection=nil>

---------

Co-authored-by: LaRita Robinson <larita@scientist.com>
@ShanaLMoore ShanaLMoore mentioned this issue Aug 14, 2024
Merged
ShanaLMoore added a commit that referenced this issue Aug 14, 2024
@ShanaLMoore
Oai customizations (#735)
f3c3273 
# Story

Locally, point to bulkrax branch: handle-remote-files-for-valkyrie

Refs

- #708
- #723

# Expected Behavior Before Changes

# Expected Behavior After Changes

# Screenshots / Video

<details>
<summary></summary>

</details>

# Notes
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Sep 5, 2024 •
edited
Loading

QA RESULTS: ✅ PASS

Tested on STAGING IMPORTER

Confirming work with identifier: 20121836

OAI FEED:

Image

THUMBNAIL URL: https://adl-ebstore-repo.s3.amazonaws.com/20/1218/20121836/20121836.TN.jpg =>

Image

WORK thumbnail file (*.TN.jpg) matches:

Image

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShanaLMoore ShanaLMoore

@laritakr laritakr

Labels
Bulkrax high priority Valkyrie
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ShanaLMoore @laritakr