update to hyrax 2.2 #1543
Merged
update to hyrax 2.2 #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see a bunch of these errors: |
|
Good news is that I can always get the same failures on CI. Bad news is I can not get them locally (I get a full green run). I'll keep digging on this. |
…ra#1525) * add 'license' to primary_terms * Test
ghost
previously approved these changes
Oct 4, 2018
There was a problem hiding this comment.
@orangewolf I'm approving this ... those collection failures are fixed in #1548
|
@geekscruff thank you! I've merged #1548 in here to see if we can get one branch that's green to merge in |
ghost
merged commit 
ghost
mentioned this pull request
mankind
pushed a commit
to ubiquitypress/hyku
that referenced
this pull request
Sep 25, 2019
* update to hyrax 2.2
jeremyf
added a commit
that referenced
this pull request
Dec 20, 2023
Per https://github.com/samvera/hyku/releases/tag/v5.0.0, these importers have been deprecated. The "Commit History of Directories" shows that there as been little activity, the recent activity being appeasing Rubocop and working through upgrades. Further, these files are conceptually subsumed by Bulkrax. <details><summary>Commit History of Directories</summary> ```bash ❯ git slog lib/importer * 6a48652 — Hyrax 5 upgrade rubocop fixes & get specs running in CI (#2065) LaRita Robinson, (2023-12-16) * 59626ef — 🧹 Rubocop'd lengths and other low hanging fruit Kirk Wang, (2023-12-13) * fecb4e9 — 🧹 Ran `bundle exec rubocop -a` Kirk Wang, (2023-12-13) * 0a6d047 — Upgrade to Hyrax 3.4.0 (#1811) Rob Kaufman, (2022-07-07) * edafd85 — Rubocop fixes (#1640) Rob Kaufman, (2020-08-04) * 9326387 — update to hyrax 2.2 (#1543) Rob Kaufman, (2018-10-04) * 7526936 — Merge pull request #1541 from ubiquitypress/hyku-csv-importer Rob Kaufman, (2018-08-21) |\ | * 904a369 — Remove :files from attributes Remove method to replace existing file_set Claire, (2018-07-20) (tag: v1.0.0) | * 1cf7f5c — WIP- set uploaded_files param to use existing Actor Claire, (2018-07-19) | * 9650e54 — Restore callbacks Claire, (2018-07-12) | * e6a358a — Coerce UploadedFile to an array and use upstream Job Claire, (2018-07-11) | * 93cb695 — Import files from CSV Claire, (2018-07-06) * | bc51174 — Hyrax 2.1 upgrade (#1529) Rob Kaufman, (2018-07-26) |/ * 116d4b9 — Upgrade Hyrax to 2.0.2 and upgrade gems with security vulnerabilities (#1519) Julie Allinson, (2018-03-22) * d85952b — Changes necessary to get simple CSV import to run Michael J. Giarlo, (2017-08-22) * a4024f4 — Make ObjectFactory rubocop-clean Joe Atzberger, (2017-08-22) * 7618c3a — Refactor csv_importer and improve test accuracy Joe Atzberger, (2017-08-22) * 21eb1e6 — Add a note about a broken method Justin Coyne, (2017-06-15) * 86eedaa — Update Hyrax and other dependencies Justin Coyne, (2017-04-13) * bfecea2 — Refactor importers to use Hyrax's actor stack Justin Coyne, (2017-02-23) * 554b8a8 — Pass ability to the actor Justin Coyne, (2017-02-17) * a8b25cd — Point at the Hyrax repo Justin Coyne, (2016-12-03) * 5d005c9 — [WIP] Hyrax! Justin Coyne, (2016-12-02) * fe229ca — Rename Lerna to Hyku. Fixes #461 Justin Coyne, (2016-11-07) * 1f5fe23 — Update dependencies, Sufia to 7.0.0.rc1 Justin Coyne, (2016-07-12) * d2c8fb1 — Rename hybox to lerna Michael J. Giarlo, (2016-06-08) * 5de0440 — Add a CSV importer Justin Coyne, (2016-05-23) * 5dcbb9b — Use User.batch_user instead of the deprecated batchuser Justin Coyne, (2016-05-20) * d2a6c3c — Update to latest rubocop and rubocop-rspec Chris Beer, (2016-05-20) * 642df79 — MODS/PURL importer Justin Coyne, (2016-05-19) ``` ```bash ❯ git slog spec/lib/importer/ * 1c04b9e — 🧹 Hyrax 5 upgrade additional specs (#2067) LaRita Robinson, (2023-12-18) * 6a48652 — Hyrax 5 upgrade rubocop fixes & get specs running in CI (#2065) LaRita Robinson, (2023-12-16) * fecb4e9 — 🧹 Ran `bundle exec rubocop -a` Kirk Wang, (2023-12-13) * 0a6d047 — Upgrade to Hyrax 3.4.0 (#1811) Rob Kaufman, (2022-07-07) * edafd85 — Rubocop fixes (#1640) Rob Kaufman, (2020-08-04) * f9a3a64 — Use paths based on Rails.root instead of pure relative paths Chris Colvard, (2020-07-08) * 1b3c5ed — rubocop fixes nicholas, (2018-10-12) * aeb9904 — update FactoryGirl to FactoryBot nicholas, (2018-10-09) * 93cb695 — Import files from CSV Claire, (2018-07-06) * 116d4b9 — Upgrade Hyrax to 2.0.2 and upgrade gems with security vulnerabilities (#1519) Julie Allinson, (2018-03-22) * 7618c3a — Refactor csv_importer and improve test accuracy Joe Atzberger, (2017-08-22) * 86eedaa — Update Hyrax and other dependencies Justin Coyne, (2017-04-13) * bfecea2 — Refactor importers to use Hyrax's actor stack Justin Coyne, (2017-02-23) * 8ecb861 — Require rails_helper in one place instead of 100 Joe Atzberger, (2017-02-14) * 7498ecb — Update to latest hyrax Justin Coyne, (2016-12-20) * a8b25cd — Point at the Hyrax repo Justin Coyne, (2016-12-03) * 5d005c9 — [WIP] Hyrax! Justin Coyne, (2016-12-02) * 5de0440 — Add a CSV importer Justin Coyne, (2016-05-23) * d2a6c3c — Update to latest rubocop and rubocop-rspec Chris Beer, (2016-05-20) * 642df79 — MODS/PURL importer Justin Coyne, (2016-05-19) ``` </details>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1542
As it says on the tin - New Hyrax Version
From upstreams release notes:
Hyrax 2.1 was released on May 31st, 2018. Since then, there have been new features and bug fixes. This release contributes the following updates to Hyrax:
New Features
Repository admins can configure the visibility of the registered user list, hidden by default (#3197)
Repository admins can sort the "All Works" dashboard by date, status, and visibility (#3173)
User Interface
Hides deposit agreement progress when disabled (#3141)
Adds Display Name to Workflow Roles management page (#3140)
Change "Update Attached File" button to "Save" on file_set edit view (#3145)
Hides private work metadata from public view during approval/ review workflow (#3148)
Disables Work "Save" button during multi-file uploads (#3150)
Hides cancel upload button when file upload(s) are finished (#3156)
Reduces size of Delete Button the file uploads page for better alignment (#3157)
The "Review Submissions" dashboard displays Depositor name, not system ID (#3170)
Accessibility:
Removes the aria-hidden flag that hides useful elements for screen readers (#3114)
Make Single-Use Links more accessible (#3150)
Enables zooming (#3158)
File upload buttons are now keyboard clickable (#3186)
Makes breadcrumbs accessible with appropriate labels (#3188)
Dependencies:
Formal support for Ruby 2.3, 2.4, and 2.5 (#3109)
Adds support for SolrWrapper v2.x (#3125)
Consolidate dependency on ActiveFedora::Base.logger (#3142)
Bug fixes:
Duplicate exported graphs from nested works (#3110)
Removes a duplicate pagination view from Blacklight (#3115)
Adds Hyrax namespace to collection_path route helper (#3118)
Better handling of nil responses to CollectionPresenter#description (#3137)
File counts in admin dashboard accuracy (#3154)
Allows depositor to always see their own work, even during an approval process (#3161)
Refactors:
Inverts dependencies for AdminStatsPresenter (#3140)
Expanded support for "inactive" authority terms to Rights Statements (#3122)
Updates the ImportUrlJob to use a GET instead of a HEAD request for cloud file ingest (#3130)
Moves Hyrax::WorkRelation dependency closer in the stack (#3143)
Removes instances of data: { turbolinks: false } (#3150)
@samvera/hyrax-code-reviewers