Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-google-analytics #1882

Merged
merged 4 commits into from
Jan 10, 2023
Merged

add-google-analytics #1882

merged 4 commits into from
Jan 10, 2023

Conversation

aprilrieger
Copy link
Collaborator

@aprilrieger aprilrieger commented Jan 9, 2023

Changes proposed in this pull request:

  • Adding documentation to the README
  • Adds edits to the analytics.yaml file to be inline with Hyrax's
  • Add the web and worker script
  • Update the Dockerfile to call the web script
  • Adding the env variables to each deployment values file & .env
    GOOGLE_ANALYTICS_ID env variable is listed in 1Password.

Ref ticket: scientist-softserv/palni-palci#339

Testing Instructions:

  • Navigate to a current tenant and see the ga areas of the app (Dashboard/Reports/etc) is working with no errors (if applicable)
  • Create a new tenant and navigate to that tenant and see the ga areas of the app (Dashboard/Reports/etc) is working with no errors

Images:
Screenshot 2023-01-09 at 19 56 57
Screenshot 2023-01-09 at 19 56 15
Screenshot 2023-01-09 at 19 55 41

@samvera/hyku-code-reviewers

@aprilrieger aprilrieger merged commit b2da49a into main Jan 10, 2023
@orangewolf orangewolf deleted the add-google-analytics branch January 10, 2023 17:17
@bkiahstroud bkiahstroud added the minor-ver for release notes label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants