🧹 Fix relationship links #2161
Merged
🧹 Fix relationship links #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will make sure that the set child flag transaction fires when ingesting with Bulkrax. Also fixed a weird bug where the extra space in the query was causing the query to fail.
ShanaLMoore
approved these changes
Feb 2, 2024
| # specs refer to object as @object | ||
| object ||= @object || resource | ||
|
|
||
| solr_doc['account_cname_tesim'] = Site.instance&.account&.cname | ||
| solr_doc['bulkrax_identifier_tesim'] = object.bulkrax_identifier if object.respond_to?(:bulkrax_identifier) | ||
| solr_doc['account_institution_name_ssim'] = Site.instance.institution_label | ||
| solr_doc['valkyrie_bsi'] = object.kind_of?(Valkyrie::Resource) | ||
| solr_doc['member_ids_ssim'] = object.member_ids.map(&:id) |
There was a problem hiding this comment.
Note to self: We may need a valkyrie check here? valkyrie member ids returns valkyrie objects with id keys, allowing us to map (:id). Active Fedora's member_ids are just ids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will make sure that the set child flag transaction fires when ingesting with Bulkrax. Also fixed a weird bug where the extra space in the query was causing the query to fail.
TODO: update gemfile.lock once the following gets merged
Issue: