Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow use of Google Analytics 4 #2231

Merged
merged 7 commits into from
Jun 3, 2024
Merged

allow use of Google Analytics 4 #2231

merged 7 commits into from
Jun 3, 2024

Conversation

orangewolf
Copy link
Member

Updates Hyku config to allow GA4. Sets GA4 up so that events reported to GA4 will go both to the site wide GOOGLE_ANALYTICS_ID and to a tenant specific Analytics ID if one is set.

@orangewolf orangewolf added the minor-ver for release notes label May 31, 2024
ShanaLMoore
ShanaLMoore previously approved these changes Jun 3, 2024
@ShanaLMoore
Copy link
Collaborator

Rob, is this ready to be merged?

@orangewolf
Copy link
Member Author

@ShanaLMoore yes, I think so

Copy link

github-actions bot commented Jun 3, 2024

Test Results

    3 files  ±0      3 suites  ±0   15m 35s ⏱️ - 1m 24s
1 760 tests ±0  1 729 ✅  - 1  30 💤 ±0  1 ❌ +1 
1 779 runs  ±0  1 746 ✅  - 1  32 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 8fc9c62. ± Comparison against base commit 5bf4f39.

This pull request removes 26 and adds 26 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 1062c41c-5f8c-48bf-8f37-02d3b61be9d5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit c3955145-22e1-4e16-a0f6-27056275d799
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 1df2b9ad-8e62-458c-bff6-cd61cb0c1acf
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 5cd4cc01-2f1a-4939-8dce-8411fce01e9a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 0fb89d2f-9366-431b-a6e6-1d8b30a4753d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit f3add88f-2680-46ca-9741-3580d95d9a74
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to read 8eaa9c0b-63d8-4821-ae94-28213558065c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to update cef615db-560d-4bcd-a13d-afc6c38a2842
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to destroy b829d9d7-9165-40ad-912e-e622bb81fa67
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to edit 34d67405-3b7d-4520-83cf-c19ba8ddf584
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 72c4480e-1fce-4157-a115-25fb2e593fab
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit d6720f0f-5beb-49bc-b490-b2cf94f2ca65
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read aa729d74-c181-46a2-ac7c-c875f9f9ed5d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update f8f8ea4c-873f-488f-ac28-920171c1079e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy a045f0fe-52df-4053-a72e-7cb196258bf0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 775b4cc5-63c8-420c-8d0c-d4f9dbd2b392
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to read 7606d3ba-00f6-42e8-8345-646ea66bbc99
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to update a908c934-bb6e-400f-8968-562c6346f8a1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to destroy 8193ec5f-bbc1-4246-acbf-583407d65dff
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to edit 25832186-0ab0-4ce9-a992-549210d89534
…

@orangewolf orangewolf merged commit cd225d0 into main Jun 3, 2024
7 of 10 checks passed
@orangewolf orangewolf deleted the analytics_4_updates branch June 3, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants