Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix collection search & facet #2238

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

laritakr
Copy link
Collaborator

@laritakr laritakr commented Jun 7, 2024

human_readable_type has been replaced by generic_type.

Refs scientist-softserv/hykuup_knapsack#226

This fixes

  1. the All Collections button now finds collections
  2. the catalog search now includes collections in the Type section
Screenshots

Screenshot 2024-06-07 at 2 34 53 PM

Screenshot 2024-06-07 at 2 35 36 PM

`human_readable_type` has been replaced by `generic_type`.
@laritakr laritakr added the patch-ver for release notes label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

Test Results

    3 files  ±0      3 suites  ±0   16m 5s ⏱️ -9s
1 760 tests ±0  1 730 ✅ ±0  30 💤 ±0  0 ❌ ±0 
1 779 runs  ±0  1 747 ✅ ±0  32 💤 ±0  0 ❌ ±0 

Results for commit cf037ef. ± Comparison against base commit 6ccf88a.

This pull request removes 26 and adds 26 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 00043754-9a0a-46c2-8e7c-cd94aa081707
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit e8ccdbfe-9733-44e1-94b6-fb2f1df112cb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 73590d59-d053-499f-88df-29c429dc4cb5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update e912d524-bcb5-43dc-b3e9-d8863d91f133
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 086f5829-07fb-41d5-b4d3-d520282caf41
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 941be16b-86b2-45e8-ba68-06f41e940059
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to read b9d26d74-762f-4836-8f97-db5700b4e532
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to update 6cb1928b-6faa-4001-b574-b5c9c7582a84
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to destroy e279eda5-7b72-4b55-8615-ba8c8bd5763b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to edit 6702aa0b-3d02-4b1d-a78d-3299a3efe533
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 8dd5fcfd-bc36-45a1-9d05-7ea0a22db953
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 6a664eb4-4d7c-4a44-943a-288de6eb8db8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 62895de1-3b79-49ee-9f87-852a6fd6f6bc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 8204931d-b427-4eb0-8097-727eb9a07693
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy a41667b5-4090-4ee1-9c7b-f32844097605
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit c56e67da-26ac-4446-ac31-85f837324a42
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to read f135f1fe-8c06-4bb1-ac8b-bdd3e95fc79b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to update 4f61495d-8c44-4d69-b6d6-e24398cef39e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to destroy 343b9316-01fe-4529-8d12-a1f548ebf45b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to edit af218d67-2391-49c8-8514-c00a9d60e9bd
…

♻️ This comment has been updated with latest results.

@laritakr laritakr merged commit e046dd7 into main Jun 7, 2024
9 of 10 checks passed
@laritakr laritakr deleted the i226-view-all-collection branch June 7, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants