Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gallery and masonry catalog search results #2239

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

kirkkwang
Copy link
Collaborator

@kirkkwang kirkkwang commented Jun 11, 2024

Story

Issue:

🐛 Fix gallery and masonry catalog results styling

b39333f

Previously, when the user looks at the catalog search results page and
sets the view to either gallery or masonry, the styling is really off.
Here this commit should fix that and also hide the bookmarks checkbox.
Hyrax dassie does not show it so we will mimic that until further notice
since the user can't even get to the /bookmarks route.

Ref:

Update iiif_print gem

e677230

Expected Behavior Before Changes

image
image

Expected Behavior After Changes

image
image

Previously, when the user looks at the catalog search results page and
sets the view to either gallery or masonry, the styling is really off.
Here this commit should fix that and also hide the bookmarks checkbox.
Hyrax dassie does not show it so we will mimic that until further notice
since the user can't even get to the /bookmarks route.

Ref:
  - scientist-softserv/hykuup_knapsack#229
@kirkkwang kirkkwang added the patch-ver for release notes label Jun 11, 2024
Copy link

Test Results

    3 files  ±0      3 suites  ±0   16m 17s ⏱️ +8s
1 753 tests ±0  1 723 ✅ +2  30 💤 ±0  0 ❌  - 2 
1 772 runs  ±0  1 740 ✅ +2  32 💤 ±0  0 ❌  - 2 

Results for commit e677230. ± Comparison against base commit 53cf2e8.

This pull request removes 26 and adds 26 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 205010d8-aaa7-44b5-8067-63ec0d78aecc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 4353dce9-9f1b-4a44-b44b-f850a18f3e8b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 08983a73-ad1c-4696-afe5-2793b7543358
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update efc361cd-ca89-4884-9517-52d933eb9bb9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 86a5f80e-4ce1-4116-93db-3c9c061428ce
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 1380f20e-d105-4ce5-a277-f7a70fdaea90
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to read fa632f96-b84c-4d60-90b9-76d3bcb20f7a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to update 169bc798-e30b-4117-875d-9b1c943b6ac1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to destroy 59ac983b-348c-48d1-b219-ab1a4c59be1c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to edit c6cf95e7-b432-49d9-a3f7-958e8fbea0a5
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 15e4366d-2b5d-47c8-9b2c-f3158f3d07de
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit ace1e4e3-9ed9-4f95-8eed-bf5d423ef384
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 193b33de-5db0-41f4-9cd6-aa718d272e57
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 86ec2add-625e-4b5f-a3eb-a3e4461e3244
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 173102b7-68f9-4d06-83cf-27643c9627a7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit dcd06fab-5f25-488f-96de-e6ec70a39798
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to read 8c4ec188-e701-4b6c-8ee7-4a52c9effc55
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to update 174bd958-63a1-4290-9626-a4be0a8578a4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to destroy 6360261b-52bc-4210-853a-9e08175807ff
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to edit 625aa1e5-934a-44fb-b176-21c4fdc39811
…

@kirkkwang kirkkwang merged commit 1a3374d into main Jun 11, 2024
9 of 10 checks passed
@kirkkwang kirkkwang deleted the fix-gallery-and-masonry-catalog-search-results branch June 11, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants