-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gallery and masonry catalog search results #2239
Merged
kirkkwang
merged 2 commits into
main
from
fix-gallery-and-masonry-catalog-search-results
Jun 11, 2024
Merged
Fix gallery and masonry catalog search results #2239
kirkkwang
merged 2 commits into
main
from
fix-gallery-and-masonry-catalog-search-results
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the user looks at the catalog search results page and sets the view to either gallery or masonry, the styling is really off. Here this commit should fix that and also hide the bookmarks checkbox. Hyrax dassie does not show it so we will mimic that until further notice since the user can't even get to the /bookmarks route. Ref: - scientist-softserv/hykuup_knapsack#229
ShanaLMoore
approved these changes
Jun 11, 2024
Test Results 3 files ±0 3 suites ±0 16m 17s ⏱️ +8s Results for commit e677230. ± Comparison against base commit 53cf2e8. This pull request removes 26 and adds 26 tests. Note that renamed tests count towards both.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Issue:
🐛 Fix gallery and masonry catalog results styling
b39333f
Previously, when the user looks at the catalog search results page and
sets the view to either gallery or masonry, the styling is really off.
Here this commit should fix that and also hide the bookmarks checkbox.
Hyrax dassie does not show it so we will mimic that until further notice
since the user can't even get to the /bookmarks route.
Ref:
Update
iiif_print
geme677230
Expected Behavior Before Changes
Expected Behavior After Changes