Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [i70] - Removes Show PDF options as form input fields #2247

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

ShanaLMoore
Copy link
Collaborator

@ShanaLMoore ShanaLMoore commented Jun 20, 2024

Show PDF Viewer and Show PDF Download Button should not render input fields on the work's form.

Issue:

BEFORE

image

AFTER

image

Show PDF Viewer and Show PDF Download Button should not render input fields on the work's form.

Issue:
- scientist-softserv/palni_palci_knapsack#70
@ShanaLMoore ShanaLMoore added the patch-ver for release notes label Jun 20, 2024
@ShanaLMoore ShanaLMoore changed the title 🐛 [i70] - Remove Show PDF options as input fields 🐛 [i70] - Removes Show PDF options as input fields Jun 20, 2024
@ShanaLMoore ShanaLMoore changed the title 🐛 [i70] - Removes Show PDF options as input fields 🐛 [i70] - Removes Show PDF options as form input fields Jun 20, 2024
@ShanaLMoore ShanaLMoore marked this pull request as draft June 20, 2024 15:17
@ShanaLMoore
Copy link
Collaborator Author

ShanaLMoore commented Jun 20, 2024

UPDATE: FIX error caused when visiting work > edit

Screenshot 2024-06-20 at 08-17-31 Action Controller Exception caught

Copy link

github-actions bot commented Jun 20, 2024

Test Results

    3 files  ±0      3 suites  ±0   19m 44s ⏱️ + 2m 14s
2 027 tests ±0  1 982 ✅  - 1  44 💤 ±0  1 ❌ +1 
2 054 runs  ±0  2 007 ✅  - 1  46 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit e6a8c7d. ± Comparison against base commit be25615.

This pull request removes 43 and adds 43 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy b498e0e4-2489-4aa1-8520-98e947ee5bab
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit e786648d-9955-4426-b7c3-10dde5ab3cd3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 815e2320-e86e-4fe6-beb9-a8f874715bcd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update b1c5b819-cccf-4633-8287-8db4e2aaee1e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 46c4e8d2-9705-4bd7-97c8-3bb30a9e587a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit f864138c-baeb-43e0-bc3e-c35923e2faa0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read e864d2e8-f7d1-448b-ae12-8b68398d660b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 9aa6a1a1-d326-47dd-ad20-46285dd366ef
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 11bb7243-02f1-4124-9648-82afac9d9aae
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 1a37960b-5317-47fd-b4ca-51220a028588
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy bcdda597-a471-4e0a-92f0-f70ed83e0578
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 3fc9eb0f-c2e0-4e8b-aa95-ee6cfe2d2c33
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read cfe2d579-5677-441e-9ec3-c14ef619c539
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update d8421dbf-6027-4950-b26c-cf747871d0b9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy a61be50f-c5e8-4653-849d-cd108416d563
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit be4b3cd0-5c1a-4e80-9276-f650bf8cb2d7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read f689211d-515e-44ad-b0c0-b28c3d39ed46
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update c18b8365-79a8-425c-bd37-604a4c7387a7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 2dae18a9-d68a-402c-b40a-9e13f91976fd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 95187439-547a-4757-ad8a-232c4b7a53ae
…

♻️ This comment has been updated with latest results.

@ShanaLMoore ShanaLMoore marked this pull request as ready for review June 20, 2024 18:46
@ShanaLMoore
Copy link
Collaborator Author

UPDATE: FIX error caused when visiting work > edit

Screenshot 2024-06-20 at 08-17-31 Action Controller Exception caught

resolved:

image

@ShanaLMoore ShanaLMoore merged commit 7fff868 into main Jun 20, 2024
7 of 9 checks passed
@ShanaLMoore ShanaLMoore deleted the i70-remove-show-pdf-input-fields branch June 20, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants