Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bring over CsvParserDecorator fix from Pals #2249

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

kirkkwang
Copy link
Collaborator

@kirkkwang kirkkwang force-pushed the update-csv_parser_decorator branch from 6197e94 to 9564a32 Compare June 20, 2024 16:42
@kirkkwang kirkkwang added the patch-ver for release notes label Jun 20, 2024
Copy link
Collaborator

@ShanaLMoore ShanaLMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, is this file needed for pals then?

@kirkkwang
Copy link
Collaborator Author

It is not, i'm removing it

ShanaLMoore
ShanaLMoore previously approved these changes Jun 20, 2024
Copy link

github-actions bot commented Jun 20, 2024

Test Results

    3 files  ±0      3 suites  ±0   17m 53s ⏱️ +22s
2 027 tests ±0  1 983 ✅ +2  44 💤 ±0  0 ❌  - 2 
2 054 runs  ±0  2 008 ✅ +2  46 💤 ±0  0 ❌  - 2 

Results for commit 6c6f099. ± Comparison against base commit 4a0c400.

This pull request removes 43 and adds 43 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 9b9b912a-9ca9-445e-9927-09e3a789c168
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 2e4b6529-f550-49f7-88d4-3b75dce6175f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read e19e0bbc-926e-4088-aa39-a17a98329dcb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update d77a7e90-6c8d-43bf-903d-178615ac1ade
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 5672d442-710f-42e5-af0c-64fdf6ab6302
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 536e0b55-6c5f-4676-9854-7fa8e70adedc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 9dd4d78f-344b-4a58-b831-0c73cb527492
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 424df621-b744-4737-a64f-a08022b00c57
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 54d4b225-736d-4149-af58-06082165a038
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 0251f4ec-3232-4a16-a8d3-25d3c85453c6
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 5c925cdb-4980-4601-b52d-6ad9158275aa
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 48ba0926-e27a-49cd-8ba1-be4622c1ac8e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 585ecacd-b57b-4034-b602-f24439b83e38
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 1ff560fa-ec97-4446-804a-2fe93d95ab5c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 7d79e682-43b6-472a-a78c-fc62b0f54d73
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit d01d9071-7647-4667-adbf-ab82926cc8fd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 3391c29c-ede3-4552-9402-b1e33d6ca477
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update b9cdc803-583e-4732-abec-c001efa69a22
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 7518ce9d-dfb1-4f9f-b21a-1eeac0151e52
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 82db17a8-2900-4984-8da5-9ea8f54651ee
…

♻️ This comment has been updated with latest results.

@kirkkwang kirkkwang merged commit 692427f into main Jun 20, 2024
9 checks passed
@kirkkwang kirkkwang deleted the update-csv_parser_decorator branch June 20, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants