Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix Bulkrax issues for Knapsack applications #2259

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

kirkkwang
Copy link
Collaborator

We are removing the bulkrax_identifier opinion because applications should declare their own source identifiers. We are also commenting out the logic for required fields for now, it is not working for Valkyrie objects.

We are removing the bulkrax_identifier opinion because applications
should declare their own source identifiers.  We are also commenting out
the logic for required fields for now, it is not working for Valkyrie
objects.
@kirkkwang kirkkwang added the patch-ver for release notes label Jun 25, 2024
Copy link

Test Results

    3 files  ±0      3 suites  ±0   17m 37s ⏱️ -21s
2 027 tests ±0  1 977 ✅  - 6  50 💤 +6  0 ❌ ±0 
2 054 runs  ±0  2 002 ✅  - 6  52 💤 +6  0 ❌ ±0 

Results for commit 23c7dd6. ± Comparison against base commit de18ed2.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 77c0390d-14db-4d92-8cab-20613a74afd5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 5d69ee37-11af-4fb9-854c-b1ab920201a2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read a2765937-7710-4145-b9d8-77782a7baf6d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 0ca93175-ddb5-4ecd-bbb9-681ff26a0bb8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy dfd04862-a030-4226-9c24-299e7224d326
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 0b9e6ee6-9e42-43f6-a95d-154187b21375
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read e3a92cb4-19bb-4500-8ac4-116142e82a95
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 775e56b4-7d14-43d5-a436-0dd0982fa276
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 13ce306b-799f-4f07-8ce6-be3242e548f3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 3d0ceee0-6f03-4dd4-a7a7-a1ada1d53681
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 39497e00-7cf1-4ca7-ac25-19d3005071e2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 08fd3b66-df7d-4f41-b382-ad0503719c5b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 4a19df89-9f50-4e1d-b497-fbc90c0bc899
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update a75cdae5-7195-4f11-8ff2-23021c263151
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 095c7ed9-8a8b-4900-98b1-10d106689720
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit cd274f2e-f035-47ec-8922-3c2acd165713
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 9b7e476c-e441-4eff-9288-8bfd30445736
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 2e4316ac-bed6-4307-aedb-8413fb75514e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy bba165ac-deb6-4756-8314-f4b2fac3221d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 48942aa3-200c-461a-8ce3-6d704bf3f0a2
…
This pull request skips 6 tests.
spec.parsers.bulkrax.csv_parser_decorator_spec ‑ Bulkrax::CsvParserDecorator#valid_import? when all required fields are present returns true
spec.parsers.bulkrax.csv_parser_decorator_spec ‑ Bulkrax::CsvParserDecorator#valid_import? when required fields are missing rescues the error and calls set_status_info
spec.parsers.bulkrax.csv_parser_decorator_spec ‑ Bulkrax::CsvParserDecorator#valid_import? when required fields are missing returns false
spec.parsers.bulkrax.csv_parser_decorator_spec ‑ Bulkrax::CsvParserDecorator#valid_import? when the csv header is a sequential number still returns true
spec.parsers.bulkrax.csv_parser_decorator_spec ‑ Bulkrax::CsvParserDecorator#valid_import? when the csv header is the parser_mappings value still returns true
spec.parsers.bulkrax.csv_parser_decorator_spec ‑ Bulkrax::CsvParserDecorator#valid_import? when the csv headers are in any case (capitalized or lowercased) still returns true

@kirkkwang kirkkwang merged commit e7ac989 into main Jun 25, 2024
9 of 10 checks passed
@kirkkwang kirkkwang deleted the fix-bulkrax-issues-for-knapsack branch June 25, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants