Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling updates #2263

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Styling updates #2263

merged 2 commits into from
Jul 8, 2024

Conversation

kirkkwang
Copy link
Collaborator

Fix facet count styling

15e8b91

This commit will align the facet count to the end of the flex row.

Before

image

After

image

Update Hyrax and remove some overrides

d941cfc

This commit will update Hyrax to include some fixes to the UI that we
overrode in Hyku. Now that the changes have been merged to Hyrax we can
go ahead and remove the overrides after updating to the latest revision.

app/assets/stylesheets/hyku.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/hyku.scss Outdated Show resolved Hide resolved
@kirkkwang kirkkwang added the patch-ver for release notes label Jul 5, 2024
@kirkkwang kirkkwang force-pushed the styling-updates branch 2 times, most recently from 64e2266 to 43a8a9c Compare July 5, 2024 23:39
This commit will align the facet count to the end of the flex row.
This commit will update Hyrax to include some fixes to the UI that we
overrode in Hyku.  Now that the changes have been merged to Hyrax we can
go ahead and remove the overrides after updating to the latest revision.
Copy link

github-actions bot commented Jul 6, 2024

Test Results

    3 files  ±0      3 suites  ±0   19m 7s ⏱️ + 1m 15s
2 027 tests ±0  1 977 ✅ ±0  50 💤 ±0  0 ❌ ±0 
2 054 runs  ±0  2 002 ✅ ±0  52 💤 ±0  0 ❌ ±0 

Results for commit 408563e. ± Comparison against base commit 5b80a96.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 6496d6b3-316c-4868-a7aa-42b6dd730e18
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 8a5330eb-e9a9-4101-9a33-ebe556787861
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read fe922d85-e135-4f9e-b796-3ea29c430e8e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update b7f78785-1d17-4b1c-b9e5-e9d7ea7f0afe
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy eba45864-cd3c-4257-b7f6-1f9a5e43f9cc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 4143ae78-3c2b-46fe-8f5f-09c2fe8b054c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 6e1974b5-2647-4e72-8f3d-8275d74accdd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 10cd9e5f-259b-4904-9bde-b707b8805495
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 896a1537-d494-476f-ad60-b15598e0be8a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 95af01e8-ac2e-49b7-9aab-6ab35988a341
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy bc6bdfbf-0045-445a-8269-da21e2822d62
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit b2448f2d-0e94-42c9-aa0a-9b59eadf8a21
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read aa36c637-5f73-4c2b-af0e-85198f3ed5d1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 60b619c5-fa3c-4a43-b517-7c965e9fc228
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 87cc0476-5321-4eef-96e9-94bddaad47f1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit a3551a11-41c7-42f6-8663-0d7f44e6d9e4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read c508d266-1fbf-4efa-aa0b-6c11e6bbaa6d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update c93855c0-0bef-4ff9-af1d-c029325d337a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 36a223c8-9304-434b-963c-135fb2bfd9d7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit c1b1ebd5-0eca-44f9-9779-fd2c3a2e6e0f
…

♻️ This comment has been updated with latest results.

@ShanaLMoore ShanaLMoore merged commit 00a8e6d into main Jul 8, 2024
9 checks passed
@ShanaLMoore ShanaLMoore deleted the styling-updates branch July 8, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants