Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Fix QuickClassificationQuery leaky spec #2264

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

kirkkwang
Copy link
Collaborator

The Hyrax::QuickClassificationQuery spec was leaking into other specs because the user ability was being loaded with just the GenericWork. Loading Hyrax::ModelRegistry.work_classes seems to ensure things are loaded correctly.

The Hyrax::QuickClassificationQuery spec was leaking into other specs
because the user ability was being loaded with just the GenericWork.
Loading Hyrax::ModelRegistry.work_classes seems to ensure things are
loaded correctly.
@kirkkwang kirkkwang added the patch-ver for release notes label Jul 10, 2024
Copy link

Test Results

    3 files  ±0      3 suites  ±0   18m 15s ⏱️ +12s
2 027 tests ±0  1 977 ✅ ±0  50 💤 ±0  0 ❌ ±0 
2 054 runs  ±0  2 002 ✅ ±0  52 💤 ±0  0 ❌ ±0 

Results for commit d7f9b85. ± Comparison against base commit 00a8e6d.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy ae878231-4963-4068-a63e-7b7ee8297b7b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit a57d6a3b-c229-4161-b5cc-1bbba5da409b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read ab3fe18e-0eb6-478b-92c9-06aafb843e92
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update ea903f6a-89ea-43e0-a261-23677ead984e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 4a5797dc-760b-4c52-aaf1-f5425dfead20
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit cae613db-b45a-485f-9a9c-087ba027eeb4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read bab6c4d3-5827-4c1f-a494-12657f9ac6e9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 3e97705f-3dd3-472f-9d99-5cbfda834aac
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 6a81c5e9-e896-466e-bd29-4c5e304aaba4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 5a4c3e4d-c966-4a1b-ac4a-290ab713b7b1
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 02361b69-c5d5-43f3-a11c-213079a7ed22
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 8ae9db06-cad6-47aa-a8b6-3fcb5cc40445
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read bf508868-9fcd-43b1-8f49-268be24212c0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 43081e53-c209-45f1-9f65-a3896eb2a618
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 2204c6d4-8aef-4d7e-8c2b-a41bb12ba867
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit cf365a19-96b8-4e5b-8c1a-421eeca8081b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 1e3403ce-3f6d-4bc1-ac1b-5b0783025bef
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 664e5380-102f-4e2e-af15-fe4dbf5ab7d0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 9c7397e7-fac1-42c0-9d6e-c9512a0d844c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 4a4d176b-321e-4412-9dca-6c18e1891c2a
…

@ShanaLMoore ShanaLMoore merged commit ddfd479 into main Jul 10, 2024
9 of 10 checks passed
@ShanaLMoore ShanaLMoore deleted the fix-quick-classificiation-leaky-spec branch July 10, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants