Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I769 snippets #2329

Merged
merged 5 commits into from
Sep 19, 2024
Merged

I769 snippets #2329

merged 5 commits into from
Sep 19, 2024

Commits on Sep 18, 2024

  1. 🎁 Implement all_text searching in Valkyrie for PDF

    This commit will introduce the Hyku::Indexers::FileSetIndexer to add
    indexing logic for born digital PDFs when using PDF.js.  We also change
    the works' indexing field to match the file sets' indexing field
    (all_text_tsimv).  We also "valyrized" the logic in the HykuIndexing
    module to accomplish this.
    
    Ref:
    - scientist-softserv/adventist_knapsack#769
    kirkkwang committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    54bf5d7 View commit details
    Browse the repository at this point in the history
  2. 🎁 Add logic for snippets when splitting PDFs

    This commit will add logic to add the ability to see search snippets
    with PDFs that were split through IIIF Print.
    kirkkwang committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b666d84 View commit details
    Browse the repository at this point in the history
  3. ✅ Add test for file set indexer logic

    This commit will add a simple test for the FileSetIndexer logic to check
    that the text extraction from a born digital pdf works as expected.
    kirkkwang committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9aa21fc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    685266d View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. ✅ Fix indexer specs

    This commit will rename the #full_text method to #extract_full_text
    because it was causing weird issues with super.
    kirkkwang committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    617bc24 View commit details
    Browse the repository at this point in the history