Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Change link_to_search to link_to_facet #2337

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

kirkkwang
Copy link
Collaborator

This commit will update the CatalogController to use the Blacklight 7 option link_to_facet.

Ref:

Before

image

After

image

@kirkkwang kirkkwang added the patch-ver for release notes label Sep 19, 2024
Copy link

github-actions bot commented Sep 19, 2024

Test Results

    3 files  ±0      3 suites  ±0   17m 35s ⏱️ -15s
2 036 tests ±0  1 986 ✅ +1  50 💤 ±0  0 ❌  - 1 
2 063 runs  ±0  2 011 ✅ +1  52 💤 ±0  0 ❌  - 1 

Results for commit e282c33. ± Comparison against base commit c09966b.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy d4573694-ff57-404a-9c6a-2e47171148a5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 87bcefe9-d8cd-4027-82d1-a1cb8c0ae25b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 4f6c8283-0857-42c7-98f8-97a7e9515f1d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update eddadff3-c8f9-434b-a5fd-333b25b75a3c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy be1479ad-e8bb-4ac9-9acc-cd553984a20d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 88db939a-1d8b-49ef-b348-b080486e4f6e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 372e5f23-ce61-4fb2-b277-5bddce728ab9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 59bcaeda-3497-4086-a951-15edc84e8113
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy f739b6b7-45b4-478e-ab5a-e8641a39e528
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit c570698b-49cd-4c8a-a51c-e7b9605d83c1
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy f55cb486-2ae2-471a-83a0-fd5ef7f4bd08
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 19e6b12b-8718-417d-aa15-d355c92ee5ee
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read ecafa4a9-cd7d-40a8-a560-2624f0f7d5f0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 20214017-c71b-497c-9042-5e46f438b4ad
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy a15947ed-5da2-48bc-a04b-c4ad71470070
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 4713a87e-1208-4f6e-b813-1abe739e5547
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 5f064093-e0bb-4d38-9621-d48d34cd2364
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update fadf3563-67cd-4662-9847-fb99f0053719
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 378825ec-0ea1-451d-a50f-49fd4b699e0b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 99a4ad4d-fea5-4ea3-afe7-f38326279aef
…

♻️ This comment has been updated with latest results.

@orangewolf orangewolf merged commit 4309a7a into main Sep 20, 2024
8 of 9 checks passed
@orangewolf orangewolf deleted the search-result-facet-links branch September 20, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants