form save failure error message improvements (#6679)

* form save failure error message improvements

* Removing trailing } which makes for bad grammar

---------

Co-authored-by: Rob Kaufman <rob@notch8.com>

app/controllers/concerns/hyrax/works_controller_behavior.rb

@@ -227,7 +227,13 @@ def form_err_msg(form)
     end
 
     def transaction_err_msg(result)
-      result.failure.first
+      msg = if result.failure[1].respond_to?(:full_messages)
+              "#{result.failure[1].full_messages.to_sentence} [#{result.failure[0]}]"
+            else
+              result.failure[0].to_s
+            end
+      Rails.logger.info("Transaction failed: #{msg}\n  #{result.trace}")
+      msg
     end
 
     def presenter

app/services/hyrax/custom_queries/navigators/parent_work_navigator.rb

@@ -33,7 +33,7 @@ def find_parent_work(resource:)
           if results.count > 1
             Hyrax.logger.warn("#{resource.work? ? 'Work' : 'File set'} " \
                               "#{resource.id} is in #{results.count} works when it " \
-                              "should be in no more than one.")
+                              "should be in no more than one. Found in #{results.map(&:id).join(', ')}.")
           end
           results.first
         end

spec/services/hyrax/custom_queries/navigators/parent_work_navigator_spec.rb

@@ -29,7 +29,7 @@
         let(:child_work3) { FactoryBot.valkyrie_create(:hyrax_work, id: 'cw3', title: ['Child Work 3']) }
         let(:member_ids) { [child_work3.id] }
         it 'logs warning about more than one parent and returns the first parent work as Valkyrie resources' do
-          expect(Hyrax.logger).to receive(:warn).with("Work cw3 is in 2 works when it should be in no more than one.")
+          expect(Hyrax.logger).to receive(:warn).with("Work cw3 is in 2 works when it should be in no more than one. Found in pw1, pw2.")
           parent = custom_query_service.find_parent_work(resource: child_work3)
           # There is no guarantee which of the parents will be returned.
           expect([work.id, parent_work.id]).to include parent.id
@@ -47,7 +47,7 @@
         let(:fileset3) { FactoryBot.valkyrie_create(:hyrax_file_set, id: 'fs3', title: ['Child File Set 3']) }
         let(:member_ids) { [fileset3.id] }
         it 'logs warning about more than one parent and returns the first parent work as Valkyrie resources' do
-          expect(Hyrax.logger).to receive(:warn).with("File set fs3 is in 2 works when it should be in no more than one.")
+          expect(Hyrax.logger).to receive(:warn).with("File set fs3 is in 2 works when it should be in no more than one. Found in pw1, pw2.")
           parent = custom_query_service.find_parent_work(resource: fileset3)
           # There is no guarantee which of the parents will be returned.
           expect([work.id, parent_work.id]).to include parent.id