refactor and DRY up the multiple form error methods into #form_errors.

app/helpers/hyrax/work_form_helper.rb

@@ -99,109 +99,9 @@ def form_file_set_select_for(parent:)
     end
 
     ##
-    # This helper retrieves errors based on form type.
-    #
-    # @param form [Hyrax::Forms::WorkForm] or Hyrax::ChangeSet
-    # @return [String] specific error message
-    def in_works_ids_errors_for(form:)
-      case form
-      when Hyrax::ChangeSet
-        form.errors[:in_works_ids]
-      else
-        form.model.errors[:in_works_ids]
-      end
-    end
-
-    ##
-    # This helper retrieves errors based on form type.
-    #
-    # @param form [Hyrax::Forms::WorkForm] or Hyrax::ChangeSet
-    # @return [String] specific error message
-    def ordered_member_ids_errors_for(form:)
-      case form
-      when Hyrax::ChangeSet
-        form.errors[:ordered_member_ids]
-      else
-        form.model.errors[:ordered_member_ids]
-      end
-    end
-
-    ##
-    # This helper retrieves errors based on form type.
-    #
-    # @param form [Hyrax::Forms::WorkForm] or Hyrax::ChangeSet
-    # @return [String] specific error message
-    def visibility_errors_for(form:)
-      case form
-      when Hyrax::ChangeSet
-        form.errors[:visibility]
-      else
-        form.model.errors[:visibility]
-      end
-    end
-
-    ##
-    # This helper retrieves errors based on form type.
-    #
-    # @param form [Hyrax::Forms::WorkForm] or Hyrax::ChangeSet
-    # @return [String] specific error message
-    def embargo_release_date_errors_for(form:)
-      case form
-      when Hyrax::ChangeSet
-        form.errors[:embargo_release_date]
-      else
-        form.model.errors[:embargo_release_date]
-      end
-    end
-
-    ##
-    # This helper retrieves errors based on form type.
-    #
-    # @param form [Hyrax::Forms::WorkForm] or Hyrax::ChangeSet
-    # @return [String] specific error message
-    def visibility_after_embargo_errors_for(form:)
-      case form
-      when Hyrax::ChangeSet
-        form.errors[:visibility_after_embargo]
-      else
-        form.model.errors[:visibility_after_embargo]
-      end
-    end
-
-    ##
-    # This helper retrieves errors based on form type.
-    #
-    # @param form [Hyrax::Forms::WorkForm] or Hyrax::ChangeSet
-    # @return [String] specific error message
-    def lease_expiration_date_errors_for(form:)
-      case form
-      when Hyrax::ChangeSet
-        form.errors[:lease_expiration_date_errors]
-      else
-        form.model.errors[:lease_expiration_date_errors]
-      end
-    end
-
-    ##
-    # This helper retrieves errors based on form type.
-    #
-    # @param form [Hyrax::Forms::WorkForm] or Hyrax::ChangeSet
-    # @return [String] specific error message
-    def visibility_after_lease_errors_for(form:)
-      case form
-      when Hyrax::ChangeSet
-        form.errors[:visibility_after_lease]
-      else
-        form.model.errors[:visibility_after_lease]
-      end
-    end
-
-    ##
-    # This helper retrieves errors based on form type.
-    #
-    # @param form [Hyrax::Forms::WorkForm] or Hyrax::ChangeSet
+    # @param form [WorkForm]
     # @return [String] specific error message(s)
-    def full_collections_errors(form:)
+    def form_errors(form:)
       error_messages = []
       form.errors.messages.each_value { |v| error_messages << v.first }
       error_messages.join('; ')

app/views/_flash_msg.html.erb

@@ -12,9 +12,6 @@
   <div class="alert alert-danger alert-dismissable" role="alert">
     <button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>
     <%= @form.errors.full_messages_for(:base).send(SimpleForm.error_method) %>
-    <%= render 'form_in_works_error', f: @form %>
-    <%= render 'form_ordered_members_error', f: @form %>
-    <%= render 'form_collections_error', f: @form %>
-    <%= render 'form_visibility_error', f: @form %>
+    <%= form_errors(form: @form) %>
   </div>
 <% end %>